From f228180350c670340649e8de4053d6b795d617c3 Mon Sep 17 00:00:00 2001
From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com>
Date: Sun, 22 Feb 2026 11:05:49 +0000
Subject: [PATCH] Address code review feedback: fix missing import, remove
 unused dep, improve docs

Co-authored-by: henriquescrrrr <192057244+henriquescrrrr@users.noreply.github.com>
---
 servershop/README.md                                  |  2 +-
 servershop/pom.xml                                    | 11 -----------
 .../main/java/pt/henrique/servershop/ServerShop.java  |  4 ++++
 .../java/pt/henrique/servershop/gui/CategoryGui.java  |  2 +-
 .../pt/henrique/servershop/gui/ItemDetailGui.java     |  1 +
 5 files changed, 7 insertions(+), 13 deletions(-)

diff --git a/servershop/README.md b/servershop/README.md
index 2ca4397..87269a4 100644
--- a/servershop/README.md
+++ b/servershop/README.md
@@ -211,7 +211,7 @@ You can query this with any SQLite client or DB browser to generate sales report
 ## Known Limitations
 
 - No admin GUI for viewing transaction stats (planned for v2).
-- Search functionality is planned but not implemented in v1 (click Search shows a placeholder message).
+- Search functionality is not implemented in v1 (planned for v2).
 - Items with special meta (potions, enchanted books) are excluded by default; when enabled, only the base type is priced (no meta matching).
 - The `sell-inventory` button sells **all** sellable items in the inventory at once — use with caution.
 - Quantities are capped to 64 × inventory size; extremely large transactions may be slow.
diff --git a/servershop/pom.xml b/servershop/pom.xml
index 876eb5f..2351a00 100644
--- a/servershop/pom.xml
+++ b/servershop/pom.xml
@@ -55,13 +55,6 @@
             <artifactId>sqlite-jdbc</artifactId>
             <version>3.45.1.0</version>
         </dependency>
-
-        <!-- HikariCP for DB connection pooling -->
-        <dependency>
-            <groupId>com.zaxxer</groupId>
-            <artifactId>HikariCP</artifactId>
-            <version>5.1.0</version>
-        </dependency>
     </dependencies>
 
     <build>
@@ -89,10 +82,6 @@
                         <configuration>
                             <createDependencyReducedPom>false</createDependencyReducedPom>
                             <relocations>
-                                <relocation>
-                                    <pattern>com.zaxxer.hikari</pattern>
-                                    <shadedPattern>pt.henrique.servershop.libs.hikari</shadedPattern>
-                                </relocation>
                                 <relocation>
                                     <pattern>org.sqlite</pattern>
                                     <shadedPattern>pt.henrique.servershop.libs.sqlite</shadedPattern>
diff --git a/servershop/src/main/java/pt/henrique/servershop/ServerShop.java b/servershop/src/main/java/pt/henrique/servershop/ServerShop.java
index 6c2b37c..99e238b 100644
--- a/servershop/src/main/java/pt/henrique/servershop/ServerShop.java
+++ b/servershop/src/main/java/pt/henrique/servershop/ServerShop.java
@@ -123,6 +123,10 @@ public final class ServerShop extends JavaPlugin {
     /**
      * Reloads all configuration, language, categories, and prices.
      * Called by {@code /shop reload}.
+     *
+     * <p>The transaction logger is intentionally NOT reloaded here because
+     * it holds an open database connection. The logging configuration is only
+     * read at startup; a full server restart is required to change it.
      */
     public void reload() {
         reloadConfig();
diff --git a/servershop/src/main/java/pt/henrique/servershop/gui/CategoryGui.java b/servershop/src/main/java/pt/henrique/servershop/gui/CategoryGui.java
index 26f7839..df5071b 100644
--- a/servershop/src/main/java/pt/henrique/servershop/gui/CategoryGui.java
+++ b/servershop/src/main/java/pt/henrique/servershop/gui/CategoryGui.java
@@ -146,7 +146,7 @@ public final class CategoryGui {
         if (meta != null) {
             meta.setDisplayName(lang.get("gui.prev-page"));
             meta.setLore(List.of(lang.get("gui.page-info",
-                    "page", String.valueOf(page),
+                    "page", String.valueOf(page),   // page is 0-indexed; prev page is (page-1)+1 = page
                     "total", String.valueOf(totalPages))));
             item.setItemMeta(meta);
         }
diff --git a/servershop/src/main/java/pt/henrique/servershop/gui/ItemDetailGui.java b/servershop/src/main/java/pt/henrique/servershop/gui/ItemDetailGui.java
index 4256d05..27ae7be 100644
--- a/servershop/src/main/java/pt/henrique/servershop/gui/ItemDetailGui.java
+++ b/servershop/src/main/java/pt/henrique/servershop/gui/ItemDetailGui.java
@@ -9,6 +9,7 @@ import pt.henrique.servershop.ServerShop;
 import pt.henrique.servershop.category.Category;
 import pt.henrique.servershop.i18n.LangManager;
 import pt.henrique.servershop.pricing.ItemPrice;
+import pt.henrique.servershop.pricing.PricingService;
 import pt.henrique.servershop.util.ItemUtil;
 import pt.henrique.servershop.util.TextUtil;